Make sure RpcEventLoop is Send+Sync #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
approved these changes
Oct 9, 2019
server-utils/src/reactor.rs
Outdated
| mod tests { | ||
| use super::*; | ||
|
|
||
| fn send_and_sync<T: Send + Sync>(_: T) {} |
Contributor
There was a problem hiding this comment.
I would have actually write this without args, and also I would have put it in the test itself as it is not useful to reuse
Suggested change
| fn send_and_sync<T: Send + Sync>(_: T) {} | |
| fn send_and_sync<T: Send + Sync>() {} |
niklasad1
reviewed
Oct 10, 2019
| lazy_static = "1.1.0" | ||
| log = "0.4" | ||
| tokio = { version = "0.1" } | ||
| tokio = { version = "0.1.15" } |
Contributor
There was a problem hiding this comment.
tokio = "0.1.22" is the latest BTW
Contributor
Author
There was a problem hiding this comment.
Yes, but we don't really require the latest. I just tested that 0.1.15 is enough to fix the Send + Sync issue, so that's the minimal version we support.
Contributor
There was a problem hiding this comment.
All right, cool I was confused by the commit message then
Contributor
Author
There was a problem hiding this comment.
Ah, yeah. Good point :) I wasn't paying that much attention when writing it.
niklasad1
approved these changes
Oct 10, 2019
dvdplm
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.