Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #6500 (decl_module: frame_system as default ident) #1314

Merged
merged 8 commits into from
Jul 8, 2020
Merged

Companion for #6500 (decl_module: frame_system as default ident) #1314

merged 8 commits into from
Jul 8, 2020

Conversation

@shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Jun 25, 2020

Update decl_storage usages with frame_system as default ident for frame-system module.

paritytech/substrate#6500

@parity-cla-bot
Copy link

It looks like @shaopengw signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@shawntabrizi
Copy link
Member

imo we should update all the imports to frame_system rather than continue to use the alias, but I would accept this too for now.

@shaunxw
Copy link
Contributor Author

shaunxw commented Jun 29, 2020

imo we should update all the imports to frame_system rather than continue to use the alias, but I would accept this too for now.

All the dependencies from FRAME are renamed as frame-/pallet- prefixes removed, for example in polkadot-runtime:

polkadot/runtime/polkadot/Cargo.toml

Lines 32 to 43 in 0762de5

authority-discovery = { package = "pallet-authority-discovery", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
authorship = { package = "pallet-authorship", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
babe = { package = "pallet-babe", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
balances = { package = "pallet-balances", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
transaction-payment = { package = "pallet-transaction-payment", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
transaction-payment-rpc-runtime-api = { package = "pallet-transaction-payment-rpc-runtime-api", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
collective = { package = "pallet-collective", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
democracy = { package = "pallet-democracy", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
elections-phragmen = { package = "pallet-elections-phragmen", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
executive = { package = "frame-executive", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
finality-tracker = { package = "pallet-finality-tracker", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }
grandpa = { package = "pallet-grandpa", git = "https://github.com/paritytech/substrate", branch = "master", default-features = false }

Not sure if it's a good idea break the naming convention for system so I kept it untouched in this PR.

@shaunxw shaunxw mentioned this pull request Jun 30, 2020
Merged
@shaunxw shaunxw force-pushed the sw/frame-system-as-default-ident branch from 9ed0cb1 to e1dcabd Compare July 2, 2020 00:15
@ghost
Copy link

ghost commented Jul 7, 2020

bot merge

@ghost
Copy link

ghost commented Jul 7, 2020

Waiting for commit status...

@ghost
Copy link

ghost commented Jul 7, 2020

Failed a required check; merge cancelled.

@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Jul 8, 2020
@bkchr bkchr merged commit 1e1169d into paritytech:master Jul 8, 2020
@shaunxw shaunxw deleted the sw/frame-system-as-default-ident branch July 8, 2020 08:09
ordian pushed a commit that referenced this pull request Jul 9, 2020
Merge branch 'master' into ao-overseer-all-messages-integration
b5e49b0 
* master:
  Implement PoV Distribution Subsystem (#1344)
  Bump Substrate (#1382)
  Update the Kusama bootnode IDs (#1377)
  Companion for #6575 (Add `WeightInfo`) (#1352)
  Companion for #6599 (#1371)
  Use `SpawnNamed` to give tasks names (#1379)
  Update to substrate#59ee76a0 (#1380)
  Companion PR for #6564 (#1350)
  Companion for #6584 (#1373)
  Companion for #6500 (decl_module: frame_system as default ident) (#1314)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shaunxw @parity-cla-bot @shawntabrizi @bkchr