Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@pepyakin
Copy link
Contributor

Add a note about memory requirements for performing cargo build --release

@pepyakin pepyakin added I7-documentation Documentation needs fixing, improving or augmenting. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 14, 2020
Copy link

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add some examples of errors that can occur during build if we're out of memory. Or links to relevant issues.

@pepyakin
Copy link
Contributor Author

Agreed, the error messages could go to a troubleshooting section. Not sure about the issues though, do you mean issues of other people who experienced the same?

Anyway, I think those can be addressed in follow-ups and this particular PR improves the status quo which warrants merging as is.

@pepyakin
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 14, 2020

Waiting for commit status.

cargo build --release
```

Note that compilation can require several GiB of memory. Please make sure that the machine has that amount of physical memory or swap has enough capacity (keep in mind that if builds hit swap it tends to be very slow).
Copy link
Member

@bkchr bkchr Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have said that more than 4GB are required :P

But people will not read this anyway and will continue to open issues xD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, 4GiB is also what I had in the back of my mind. I'll file another PR

But people will not read this anyway and will continue to open issues xD

Well, maybe, but at least those who reads this can save themselves a few back and forths

@ghost ghost merged commit 1ae8d2d into master Sep 14, 2020
@ghost ghost deleted the ser-update-readme branch September 14, 2020 10:56
ordian pushed a commit that referenced this pull request Sep 14, 2020
* master:
  Companion PR for #6984 (#1661)
  Update some dependencies. (#1718)
  Add a specific memory requirements (#1716)
  Companion PR for #7039: grandpa-rpc dont share subscription manager, only executor (#1687)
  Update bytes. (#1715)
  Add a note about memory requirements (#1714)
  Update parity-multiaddr. (#1700)
  typo in proxy tests (#1713)
  Companion PR for ` Add a `build-sync-spec` subcommand and remove the CHT roots from the light sync state.` (#1670)
  Forwardport: Validation: don't detect STDIN closing when running in process (#1695) (#1703)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. I7-documentation Documentation needs fixing, improving or augmenting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants