Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion for upgrade of pallet-mmr to pallet macro #3350

Merged
1 commit merged into from
Jul 14, 2021
Merged

Companion for upgrade of pallet-mmr to pallet macro #3350

1 commit merged into from
Jul 14, 2021

Conversation

@koushiro
Copy link
Contributor

@koushiro koushiro mentioned this pull request Jun 23, 2021
Merged
@gui1117 gui1117 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 14, 2021
@gui1117
Copy link
Contributor

gui1117 commented Jul 14, 2021

we can merge before the companion because this is just removing the mmr call variant, which was an empty enum.
after the companion such a change is mandatory, but right now the change also makes sense

@gui1117
Copy link
Contributor

gui1117 commented Jul 14, 2021

bot merge

@ghost
Copy link

ghost commented Jul 14, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Batch: Codebase Restructure' does not match any projects in polkadot's Process.json

@gui1117
Copy link
Contributor

gui1117 commented Jul 14, 2021

bot merge

@ghost
Copy link

ghost commented Jul 14, 2021

Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json.

Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first.

The following errors might have affected the outcome of this attempt:

  • 'Batch: Codebase Restructure' does not match any projects in polkadot's Process.json

@KiChjang
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Jul 14, 2021

Trying merge.

@ghost ghost merged commit 43920cd into paritytech:master Jul 14, 2021
@koushiro koushiro deleted the companion-9181 branch July 14, 2021 09:41
@koushiro koushiro restored the companion-9181 branch July 14, 2021 09:41
@koushiro koushiro deleted the companion-9181 branch May 21, 2022 07:01
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@KiChjang KiChjang KiChjang approved these changes

@gui1117 gui1117 gui1117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@koushiro @gui1117 @KiChjang