This repository was archived by the owner on Nov 15, 2023. It is now read-only.
more fine grained runtime api caching + a fix for av-store #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-please_review
added 2 commits
July 12, 2021 16:10
I think so, but that assumption might be invalidated by contextual execution. We might also lean on the assumption that the runtime backs/includes candidates in block B only from the same session as B and avoid making queries about anything except the most recent block. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #2987
In order to solve #3356 (comment) IIUC we need to query a session_index_for_child for a grandparent of the head and then use the rolling session with that index, is that correct?
I guess we can also cache
authoritiesbased onsession_index_for_child, but that would require an extra call to the runtime and probably warrant some tweaks to the runtime api macros.