Improve subkey error reporting #4504
Conversation
|
It looks like @NikVolf signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
bin/utils/subkey/src/main.rs
Outdated
| Formatted(String), | ||
| } | ||
|
|
||
| fn execute_proc<C: Crypto>(matches: ArgMatches) |
There was a problem hiding this comment.
Just use fn main() -> Result<(), Error>
There was a problem hiding this comment.
It does not really pretty-print error this way, see nv-sk-err-msin branch
There was a problem hiding this comment.
If you do this:
substrate/client/network/src/error.rs
Line 51 in c3a4c55
The error message should look good.
There was a problem hiding this comment.
Better, but still worse than here if you ask me (updated nv-sk-err-msin branch)
There was a problem hiding this comment.
The only different I see is that there is no new line after Error: in the output? I think hat is okay and less code is always better, IMHO^^
NikVolf
force-pushed
the
nv-sk-err
branch
2 times, most recently
from
532eb15 to
aad663e
Compare
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Looks good, ty!
One last nitpick :)
| } | ||
|
|
||
| fn execute<C: Crypto>(matches: ArgMatches) | ||
| #[derive(derive_more::Display, derive_more::From)] |
There was a problem hiding this comment.
Could you please change the function above to return an error as well? (get_uri)
Uh oh!
There was an error while loading. Please reload this page.