--version commit hash - style improvement #496
Conversation
substrate/service/src/lib.rs
Outdated
| mod components; | ||
| mod error; | ||
| mod config; | ||
| pub mod config; |
There was a problem hiding this comment.
could you group the public module declarations together?
There was a problem hiding this comment.
New change committed to group the public module declarations together.
| pub fn platform() -> String { | ||
| let env = Target::env(); | ||
| let env_dash = if env.is_empty() { "" } else { "-" }; | ||
| format!("{}-{}{}{}", Target::arch(), Target::os(), env_dash, env) |
There was a problem hiding this comment.
are these tabs or some kind of weird half-tab? github is rendering them strangely. also in the below function
There was a problem hiding this comment.
I think it's just my attempts to get these changes into GitHub - had a few problems with this today! I'll try to correct them..
There was a problem hiding this comment.
Looking around, these strange tab sizes seem common in many files displayed on GitHub. I think it is perhaps just more noticeable in this one with the free functions.
Anyway, I tried pulling this file from Github back to my local machine and the tabs were all normal.
gavofyork
added
A8-looksgood
and removed
A0-please_review
* Update lib.rs * Update lib.rs * Update config.rs * Update lib.rs * Update lib.rs * tab correction
* update to latest substrate polkadot-master * Bump to 0.6.3
…ve-to-best-execution-chain-number-refactor Minor refactoring for better readability
Signed-off-by: Gregory Hill <[email protected]>
Moved static method
full_version_from_strsout of theConfigurationstruct to be a free function within the same module. This has simplified calls to the function by avoiding the complicated type ofConfiguration.The
platformfunction has also made the same journey for the same reasons. Additionally it is called byfull_version_from_strsso needs to be easily accessible from the new location.Closes #468