This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Clean up the public API of sc-network-gossip #5001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A2-insubstantial
tomaka
added
B0-silent
Contributor
|
I did this in #4633 but that PR is on ice because I'm waiting for a new tokio version, so LGTM. |
expenses
approved these changes
Feb 20, 2020
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's also clean up the public-facing API of
sc-network-gossipby turning the futures 0.1 into a futures 0.3.I don't know if I should mark as "client-noteworthy" considering that this concerns a trait that exists purely in order to be able to mock the network for testing purposes. Polkadot in particular doesn't implement this trait.