Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@marcio-diaz
Copy link
Contributor

@marcio-diaz marcio-diaz commented Mar 18, 2020

(In progress)

I think the code of Gav is good, so I'll just add tests/graphs to compare both algorithms and do some cleaning.
Also, we need to see the best output for the scripts that will run it.

@marcio-diaz marcio-diaz added the A3-in_progress Pull request is in progress. No review needed at this stage. label Mar 18, 2020
@marcio-diaz marcio-diaz added this to the 2.0 milestone Mar 18, 2020
@shawntabrizi
Copy link
Member

Have you tested this with some real benchmarks? Can you post the full results here?

@gavofyork gavofyork added A8-mergeoncegreen and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 23, 2020
@gavofyork gavofyork merged commit 64bfc96 into master Mar 23, 2020
@gavofyork gavofyork deleted the gav-regression branch March 23, 2020 13:07
bkchr pushed a commit that referenced this pull request Mar 24, 2020
* Add linregress

* Regression, initial stuff.

* More analytics

* whitespace

* Fix

* Median slopes regression algo

* Warnings

* Update to lastest benchmark changes.

* Use both algorithms temp.

* Move analysis to frame.

* Fix tests.

* Only build analysis in std

Co-authored-by: Gav Wood <[email protected]>
rakanalh pushed a commit to rakanalh/substrate that referenced this pull request Mar 25, 2020
* Add linregress

* Regression, initial stuff.

* More analytics

* whitespace

* Fix

* Median slopes regression algo

* Warnings

* Update to lastest benchmark changes.

* Use both algorithms temp.

* Move analysis to frame.

* Fix tests.

* Only build analysis in std

Co-authored-by: Gav Wood <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants