Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Aug 9, 2018

  • Updates libp2p, bringing hopefully some fixes. This notably increases the mplex buffer size limit again.
  • Add some diagnostic when a connection closes for the reason why it closed.

Before this PR, sometimes the local node drops a connection because the mplex buffer is full, and sometimes the remote drops the connection for an unknown reason.
After this PR, the problem is solved on our side but we still get connections closed by the remote.
While this PR doesn't show any improvement to the networking, if we suppose that the remote closes connections because this mplex buffer issue, then deploying it would solve a lot of things.

@tomaka tomaka added A0-please_review Pull request needs code review. M4-core labels Aug 9, 2018
@gavofyork
Copy link
Member

just a trace! log? there's already an info! log when a node disconnects and the reason/err is generally stated as "unknown". would be good to make that reason work

@tomaka tomaka changed the title Update libp2p and some log and yamux Update libp2p and some log Aug 10, 2018
@gavofyork
Copy link
Member

now there will be two info!s then the nodes disconnect. we should just have one that works.

@gavofyork gavofyork merged commit 740902b into paritytech:master Aug 10, 2018
@tomaka tomaka deleted the update-libp2p branch August 10, 2018 11:00
dvdplm added a commit that referenced this pull request Aug 14, 2018
* master:
  Less verbosity (#546)
  Fetching storage proofs by light client (#252)
  Gitlab CI build file for linux. (#552)
  Vote out offline authorities (#524)
  fix block body fetch for availability pruning (#539)
  Continue sync after ancestry search (#538)
  Docs Typo Fixes (#534)
  don't wait for all futures to resolve before shutdown (#536)
  Update libp2p and some log (#532)
  Mh public key for telemetry (#526)
  Td bps (#527)
  Reserved peers CLI flag (#528)
pepyakin pushed a commit that referenced this pull request Aug 24, 2018
* Update libp2p and some log and yamux

* Replace trace! with info!

* Only have one log message on disconnect
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants