This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Get rid of some dependencies #5658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
the
A2-insubstantial
bkchr
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Can we please fix this upstream?
The design of this crate seems somewhat broken.
Instead of our own crate depending on our own crates, it should be the other way around. primitive-types and all this ethereum stuff should depend on util-mem when a feature is activated.
|
cc @ordian |
NikVolf
added
A8-mergeoncegreen
and removed
A2-insubstantial
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.