Update Weights for Vesting Pallet #5708
Conversation
shawntabrizi
changed the base branch from
master
to
shawntabrizi-fix-benchmarks
shawntabrizi
force-pushed
the
shawntabrizi-vesting-weights
branch
from
d4186f7 to
c5c45e7
Compare
shawntabrizi
requested review from
Demi-Marie,
NikVolf,
Robbepop,
andresilva,
cecton,
pepyakin,
sorpaas and
tomusdrw
as code owners
shawntabrizi
changed the base branch from
shawntabrizi-fix-benchmarks
to
master
shawntabrizi
removed request for
Demi-Marie,
NikVolf,
Robbepop,
andresilva,
pepyakin,
sorpaas and
tomusdrw
|
Okay this is ready for review. Should be good based on the benchmark data. |
| /// - Assuming less than 50 locks on any user, else we may want factor in number of locks. | ||
| /// # </weight> | ||
| #[weight = 1_000_000_000] | ||
| #[weight = 300_000_000 + T::DbWeight::get().reads_writes(3, 3)] |
There was a problem hiding this comment.
do we have a rule of thumb for granularity or soundings? This, accurately, should have been around 260_000_000 or sth?
There was a problem hiding this comment.
Benchmarks are not that accurate to begin with, but yeah, rounding here is mostly just an opinion, as long as it does not extremely change the value.
There was a problem hiding this comment.
Benchmarks are not that accurate to begin with, but yeah, rounding here is mostly just an opinion, as long as it does not extremely change the value.
I am also taking into consideration the variability of locks. If this is a little bit larger, it is a little bit safer overall as more locks are introduced per user.
|
bot merge |
ghost
merged commit 8 participants
This is a PR that updates the weights for the vesting pallet based on benchmarking data collected.