This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Update weight formula for session (with new_session taking full block) #5738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thiolliere We can make this on_initialize take the full block weight. So the weight function should be an if statement, either 0 or (I think) |
gui1117
added
A3-in_progress
gui1117
commented
Apr 22, 2020
gui1117
commented
Apr 22, 2020
| } else { | ||
| // NOTE: the non-database part of the weight for `should_end_session(n)` is | ||
| // included as weight for empty block, the database part is expected to be in | ||
| // cache. |
There was a problem hiding this comment.
reviewer should double-check this statement.
gui1117
added
A0-please_review
gui1117
changed the title
gui1117
changed the title
shawntabrizi
added
A8-mergeoncegreen
and removed
A0-please_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating formula for on_initialize requires new benchmarks, and maybe new API (or every cost of SessionHandler and ShouldEndSession will have to be documented)EDIT: as suggested by shawn new_session take full block to make it easier, if in the future it is wanted we can improve on this.