This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fix runtime version cache #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use blake2 instead of xxhash for guaranteed safety - Simplify by caching the version rather than the compatibility - Additional logging
gavofyork
commented
Aug 20, 2018
| #![cfg_attr(not(feature = "std"), no_std)] | ||
| #![cfg_attr(not(feature = "std"), feature(alloc))] | ||
| //#![cfg_attr(not(feature = "std"), feature(alloc))] |
There was a problem hiding this comment.
Not sure if this is correct, but needed it to compile. @tomusdrw ?
arkpar
reviewed
Aug 20, 2018
| RuntimePreproc::ValidCode(module, version) | ||
| } | ||
| }) | ||
| Err(_) => RuntimePreproc::InvalidCode, |
There was a problem hiding this comment.
Logging error here could be useful.
There was a problem hiding this comment.
will address in next PR.
arkpar
approved these changes
Aug 20, 2018
gavofyork
added a commit
that referenced
this pull request
Aug 21, 2018
- Use blake2 instead of xxhash for guaranteed safety - Simplify by caching the version rather than the compatibility - Additional logging
dvdplm
added a commit
that referenced
this pull request
Aug 27, 2018
…and-rlpcodec * master: Contract signatures checking (#478) extrinsic-pool: use retain() (#613) rename Polkadot to Substrate in the license header via following four commands (#614) typo fixes (#608) RPC: Block number to block hash (#584) Minor fixes for nightly 2018-08-18 (#600) Time-based transaction banning (#594) (#602) cargo --force to allow CI to build. (#599) Fix logging (#587) Fix runtime version cache (#586)
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.expect