This repository was archived by the owner on Nov 15, 2023. It is now read-only.
.maintain: Replace sentry-node with local-docker-test-network #7943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sentry nodes are deprecated. Thus there is no need for `.maintain/sentry-node` to spin up a sentry node test environment. Instead this commit rewrites the setup to contain two full-connected validators and one light client. With the steps below one can now spin up a local test network with two validators, one light-client, Prometheus and Grafana. - cargo build --release - sudo docker-compose -f .maintain/local-docker-test-network/docker-compose.yml up
mxinden
added
A0-please_review
tomaka
approved these changes
Jan 21, 2021
Contributor
tomaka
left a comment
tomaka
left a comment
There was a problem hiding this comment.
I haven't tested if it works, but looks generally good to me.
romanb
approved these changes
Jan 21, 2021
Contributor
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry nodes are deprecated. Thus there is no need for
.maintain/sentry-nodeto spin up a sentry node test environment.Instead this commit rewrites the setup with an additional light client.
With the steps below one can now spin up a local test network with
two validators, one light-client, Prometheus and Grafana.
cargo build --releasesudo docker-compose -f .maintain/local-docker-test-network/docker-compose.yml upI did initially do this for #7895 to test light client requests. I hope this can be of some help for other use-cases as well, thus I am opening this as a separate pull request.