This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Migrate some more pallets to construct_runtime #7975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
commented
Jan 25, 2021
|
|
||
| pub const CALL: &<$test as frame_system::Config>::Call = &$crate::tests::CallWithDispatchInfo; | ||
| pub const CALL: &<$test as frame_system::Config>::Call = | ||
| &Call::Balances(pallet_balances::Call::transfer(0, 0)); |
There was a problem hiding this comment.
This now needs to be an instance of the actual Call from construct_runtime, so just constructing a dummy transfer. Any better idea?
There was a problem hiding this comment.
I don't have a better idea, but a comment in the code would be welcome. :)
gui1117
approved these changes
Jan 25, 2021
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: Guillaume Thiolliere <[email protected]>
bkchr
approved these changes
Jan 25, 2021
gui1117
added
B0-silent
Co-authored-by: Bastian Köcher <[email protected]>
…ntime' into aj-migrate-tests-to-construct-runtime
48 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7949. Migrates: