This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Introduce sc_peerset::DropReason #7996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
romanb
approved these changes
Jan 28, 2021
mxinden
approved these changes
Jan 29, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
bkchr
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Introduce sc_peerset::DropReason * Fix peerset tests
s3krit
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Introduce sc_peerset::DropReason * Fix peerset tests
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the following problem:
The peerset asks to open a substream with a node. The node refuses it. The PSM immediately tries again. Repeat ad vitam eternam.
We do have a reputation decrease when a node refuses a substream, but, since reputations regress towards 0 over time, it takes an infinite amount of attempts to reach the banning threshold. Plus, we don't actually want to reach the banning threshold, as this peer might have other substreams currently open and in use.
After this PR, after a node has refused a substream, it simply removed from the set of "discovered nodes" according to the peerset, meaning that no connection attempt will be tried again until the node is later re-discovered (which will happen sooner or later).
This should only affect the block announces notifications, as it is the only one not relying on reserved nodes.