Test is_inherent_required

[4meta5]

CC @JoshOrndorff

Follow up for #7941 to verify is_inherent_required implementations that return Ok(Some(Err)) require the given inherent in every block; if it is not present in a block, then check_extrinsics returns the inner error.

The changes make it mandatory to include the Extrinsic { function: Call::Test2(CallTest2::Something) } in every (test) block. If it is not included in a block, the error is returned.

original problem

We need to ensure that a storage value is set every block. Right now, we do that by panicking in on_finalize if the storage value isn't set. This panic is redundant if is_inherent_required -> Ok(Some(Err)) enforces that an inherent which sets the given storage item is included in every block.

[gui1117]

• apart from https://github.com/paritytech/substrate/pull/8002/files#r566844567 looks good to me

[gui1117]

bot merge

[ghost]

Waiting for commit status.

[ghost]

Checks failed; merge aborted.

[gui1117]

can you merge master to make CI happy ?

[4meta5]

bot merge

[ghost]

Error getting organization membership: Status code: 404 Not Found
Body:
Object({
"documentation_url": String(
"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user",
),
"message": String(
"User does not exist or is not a member of the organization",
),
})