Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@apopiak
Copy link
Contributor

@apopiak apopiak commented Feb 1, 2021

Relax the type constraints for translate to FnMut to allow passing closures to translate that mutate captured variables.
Useful for migrations where you want to e.g. count the amount of values that were migrated.

@apopiak apopiak added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 1, 2021
@apopiak apopiak mentioned this pull request Feb 1, 2021
2 tasks
@apopiak apopiak requested a review from gavofyork February 1, 2021 15:41
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure ¯\(ツ)

@apopiak
Copy link
Contributor Author

apopiak commented Feb 1, 2021

bot merge

@ghost
Copy link

ghost commented Feb 1, 2021

Waiting for commit status.

@ghost ghost merged commit b7fc46d into master Feb 1, 2021
@ghost ghost deleted the apopiak-relax-translate-closure branch February 1, 2021 16:09
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants