This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-utility to pallet attribute macro. #8326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 tasks
|
@thiolliere @ascjones Could you please help to review? Thanks! :] |
|
@shaunxw what is your Polkadot / Kusama address? I would like to open a tip for your work. |
gui1117
added
A0-please_review
Wow, thanks a lot! XD Polkadot address: |
gui1117
approved these changes
Mar 24, 2021
ascjones
approved these changes
Mar 24, 2021
|
can you merge master ? I think the github action needs the new labels and I suspect it get it from repo itself |
Done. |
|
bot merge |
|
Waiting for commit status. |
|
Head SHA changed; merge aborted. |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* Migrate pallet-utility to pallet attribute macro. * Replace 'Module' with 'Pallet' in benchmarking.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7882.
Converts the
Utilitypallet to the new pallet attribute macro introduced in #6877.Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
Utilitypallet must be careful about the name they used inconstruct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of theUtilitypallet.