-
Couldn't load subscription status.
- Fork 2.7k
Migrate pallet-scheduler to pallet attribute macro #8769
Migrate pallet-scheduler to pallet attribute macro #8769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the calls function should stay private, but otherwise it is good to me
Also in general I prefer not to format untouched code, that make review more easy.
Polkadot/Kusama/Westend correctly have Scheduler as pallet name so no migration needed
|
Sorry about the unwanted formatting, I ran cargo fmt and didn't notice the unrelated changes. Reverted most of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata for events needs to be added, others are documentation and whitespace changes.
Co-authored-by: Keith Yeung <[email protected]>
Co-authored-by: Keith Yeung <[email protected]>
Co-authored-by: Keith Yeung <[email protected]>
Co-authored-by: Keith Yeung <[email protected]>
Co-authored-by: Keith Yeung <[email protected]>
|
bot merge |
|
Trying merge. |
* migrate to pallet! * fixes * fix genesis * code review fixes * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> * Update frame/scheduler/src/lib.rs Co-authored-by: Keith Yeung <[email protected]> * fix metadata Co-authored-by: Keith Yeung <[email protected]>
Part of #7882.
Converts the
Schedulerpallet to the new pallet attribute macro introduced in #6877.Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.