Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Dec 3, 2019

Fixes: #1014

Feed back would be appreciated.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a simple and at the same time very good solutions for me.

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #1019 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
+ Coverage   91.94%   91.94%   +<.01%     
==========================================
  Files          53       53              
  Lines        5115     5118       +3     
  Branches     1145     1145              
==========================================
+ Hits         4703     4706       +3     
  Misses        412      412
Impacted Files Coverage Δ
src/CoreManager.js 100% <ø> (ø) ⬆️
src/RESTController.js 81.36% <75%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3316ac9...f44d886. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom headers to each server request

2 participants