Skip to content

allow optional HTTP POST method override for logIn user method #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

allow optional HTTP POST method override for logIn user method #1229

merged 1 commit into from
Sep 22, 2020

Conversation

@kolohelios
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #1229 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1229   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          54       54           
  Lines        5317     5320    +3     
  Branches     1199     1201    +2     
=======================================
+ Hits         4912     4915    +3     
  Misses        405      405
Impacted Files Coverage Δ
src/RESTController.js 85.54% <ø> (ø)
src/ParseUser.js 83.16% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d37485...e1d8791. Read the comment docs.

dplewis
dplewis suggested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I was just thinking about this. I don't think this will work without server update.

I added a fix last week here. If you write an integration test it might fail.

dplewis
dplewis approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dplewis dplewis removed the release label Sep 22, 2020
@dplewis dplewis merged commit d9cc4d2 into parse-community:master Sep 22, 2020
@TomWFox TomWFox mentioned this pull request Sep 23, 2020
Merged
@rabidaudio rabidaudio mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dplewis dplewis dplewis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kolohelios @dplewis