Improve initialization setters/getters #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
==========================================
- Coverage 92.40% 92.38% -0.02%
==========================================
Files 54 54
Lines 5331 5321 -10
Branches 1203 1203
==========================================
- Hits 4926 4916 -10
Misses 405 405
Continue to review full report at Codecov.
|
dplewis
requested review from
a team and
davimacedo
and removed request for
a team
davimacedo
approved these changes
Oct 23, 2020
This was referenced Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #491
I've randomly seen users post about not being able to set the
serverURL. It's usually typescript / web pack / babel issue withdefineProperty.https://parseopensource.slack.com/archives/C011ZF86LR2/p1600690460002100
Thoughts?