Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Oct 29, 2020

Giving the SDK some much needed love

Fixes a few bugs

  • Set default emitter error on LiveQueryClient to prevent crashing
  • Query subscriptions will return error on socket error
  • WeChat socket sets handlers first before connecting
  • Fix Parse Installation error message
  • ParseACL remove unreachable code

@ghost
Copy link

ghost commented Oct 29, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@dplewis dplewis requested review from davimacedo and mtrezza October 29, 2020 00:25
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #1241 into master will increase coverage by 7.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
+ Coverage   92.46%   99.98%   +7.51%     
==========================================
  Files          54       57       +3     
  Lines        5307     5401      +94     
  Branches     1198     1198              
==========================================
+ Hits         4907     5400     +493     
+ Misses        400        1     -399     
Impacted Files Coverage Δ
src/ParseACL.js 100.00% <ø> (+5.93%) ⬆️
src/LiveQueryClient.js 100.00% <100.00%> (+12.23%) ⬆️
src/ParseConfig.js 100.00% <100.00%> (+12.04%) ⬆️
src/ParseFile.js 100.00% <100.00%> (+2.22%) ⬆️
src/ParseInstallation.js 100.00% <100.00%> (+83.33%) ⬆️
src/ParseQuery.js 99.85% <100.00%> (+3.79%) ⬆️
src/ParseUser.js 100.00% <100.00%> (+16.83%) ⬆️
src/Socket.weapp.js 100.00% <100.00%> (ø)
src/Xhr.weapp.js 100.00% <0.00%> (ø)
src/StorageController.weapp.js 100.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd25f5...cdb4c1b. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job @dplewis LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants