Skip to content

Allow nested increment on undefined fields #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Allow nested increment on undefined fields #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd1e22
remove ignore code
dplewis Feb 23, 2021
392d822
remove test
dplewis Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions integration/test/ParseObjectTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,16 +414,6 @@ describe('Parse Object', () => {
assert.equal(result.get('objectField').unknown, 20);
});

it('ignore set nested fields on new object', async () => {
const obj = new TestObject();
obj.set('objectField.number', 5);
assert.deepEqual(obj._getPendingOps()[0], {});
assert.equal(obj.get('objectField'), undefined);

await obj.save();
assert.equal(obj.get('objectField'), undefined);
});

it('can set nested fields two levels', async () => {
const obj = new TestObject({ objectField: { foo: { bar: 5 } } });
assert.equal(obj.get('objectField').foo.bar, 5);
Expand Down
9 changes: 0 additions & 9 deletions src/ParseObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,15 +741,6 @@ class ParseObject {

const currentAttributes = this.attributes;

// Only set nested fields if exists
const serverData = this._getServerData();
if (typeof key === 'string' && key.includes('.')) {
const field = key.split('.')[0];
if (!serverData[field]) {
return this;
}
}

// Calculate new values
const newValues = {};
for (const attr in newOps) {
Expand Down
10 changes: 0 additions & 10 deletions src/__tests__/ParseObject-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -699,16 +699,6 @@ describe('ParseObject', () => {
expect(o.get('objectField').letter).toEqual('a');
});

it('ignore set nested field on new object', () => {
const o = new ParseObject('Person');
o.set('objectField.number', 20);

expect(o.attributes).toEqual({});
expect(o.op('objectField.number') instanceof SetOp).toBe(false);
expect(o.dirtyKeys()).toEqual([]);
expect(o._getSaveJSON()).toEqual({});
});

it('can add elements to an array field', () => {
const o = new ParseObject('Schedule');
o.add('available', 'Monday');
Expand Down