Skip to content

Conversation

@davimacedo
Copy link
Member

No description provided.

@davimacedo davimacedo requested review from dplewis and mtrezza July 12, 2021 17:14
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1384 (fd74e5d) into master (2e7a406) will not change coverage.
The diff coverage is n/a.

❗ Current head fd74e5d differs from pull request most recent head 83c6df7. Consider uploading reports for the commit 83c6df7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1384   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          61       61           
  Lines        5943     5943           
  Branches     1350     1350           
=======================================
  Hits         5890     5890           
  Misses         52       52           
  Partials        1        1           
Impacted Files Coverage Δ
src/OfflineQuery.js 86.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7a406...83c6df7. Read the comment docs.

@davimacedo
Copy link
Member Author

Yes. It looks good to me. It's important to merge this one because the docs failed to build on last release.

@mtrezza
Copy link
Member

mtrezza commented Jul 23, 2021

Yes, sorry for the long wait time, I noticed earlier that I only subscribed to releases of this repo, so I never received any notifications for review.

@mtrezza mtrezza merged commit 163745e into master Jul 23, 2021
@mtrezza mtrezza deleted the fixDocsBuild branch October 24, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants