Skip to content

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented Sep 18, 2022

New Pull Request Checklist

Issue Description

Fully regenerates package-lock.json

Related issue: #1515
Closes: #1515

Approach

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 18, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Base: 99.94% // Head: 99.94% // No change to project coverage 👍

Coverage data is based on head (7fad1fa) compared to base (ca7d448).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1553   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5955     5955           
  Branches     1360     1360           
=======================================
  Hits         5952     5952           
  Misses          3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented Sep 18, 2022

All checks pass! I guess the issue is solved, is this ready for merge?

@dblythy
Copy link
Member Author

dblythy commented Sep 18, 2022

Yep! 😊

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title fix: regenerate lockflie refactor: regenerating package-lock.json file Sep 18, 2022
@mtrezza mtrezza changed the title refactor: regenerating package-lock.json file refactor: regenerate package-lock.json file Sep 18, 2022
@mtrezza mtrezza merged commit 3b5683b into parse-community:alpha Sep 18, 2022
@dblythy dblythy deleted the regenerate-lockfile branch September 18, 2022 10:55
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 21, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 25, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package-lock out of sync

3 participants