Skip to content

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented Dec 29, 2022

New Pull Request Checklist

Issue Description

Closes: #1638

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 29, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (0b2985c) compared to base (82e9d53).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1643   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5973     5973           
  Branches     1367     1367           
=======================================
  Hits         5967     5967           
  Misses          6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented Jan 5, 2023

Is this ready for merge?

@dblythy
Copy link
Member Author

dblythy commented Jan 6, 2023

Yep!

@mtrezza mtrezza changed the title feat: Add node 19 support feat: Add Node 19 support Jan 6, 2023
@mtrezza mtrezza merged commit dfb5196 into parse-community:alpha Jan 6, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 6, 2023
# [4.0.0-alpha.5](4.0.0-alpha.4...4.0.0-alpha.5) (2023-01-06)

### Features

* Add node 19 support ([8ed0fab](8ed0fab))
* Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.5

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 6, 2023
@dblythy dblythy deleted the node-19 branch January 6, 2023 12:37
mtrezza pushed a commit to mtrezza/Parse-SDK-JS that referenced this pull request Jan 22, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2023
# [4.0.0-beta.1](3.5.1...4.0.0-beta.1) (2023-01-23)

### Bug Fixes

* `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174))
* Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b))

### Features

* Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31))
* Add node 19 support ([8ed0fab](8ed0fab))
* Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196))

### Performance Improvements

* Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419))

### BREAKING CHANGES

* Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))
* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 23, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2023
# [4.0.0](3.5.1...4.0.0) (2023-01-23)

### Bug Fixes

* `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174))
* Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b))

### Features

* Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31))
* Add node 19 support ([8ed0fab](8ed0fab))
* Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196))

### Performance Improvements

* Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419))

### BREAKING CHANGES

* Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))
* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Node 19 support

3 participants