fix: Calling Parse.Object.relation.add multiple times adds only the first object
#2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request! |
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2078 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 61 61
Lines 6178 6173 -5
Branches 1496 1494 -2
=========================================
- Hits 6178 6173 -5 ☔ View full report in Codecov by Sentry. |
mtrezza
reviewed
Feb 15, 2024
mtrezza
requested changes
Feb 15, 2024
|
Done @mtrezza . Weird that this is how it is set up. I did not explicitly disable it. |
mtrezza
approved these changes
Feb 15, 2024
mtrezza
changed the title
Parse.Object.relation.add multiple times adds only the first object
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 15, 2024
## [4.3.1-alpha.2](4.3.1-alpha.1...4.3.1-alpha.2) (2024-02-15) ### Bug Fixes * Calling `Parse.Object.relation.add` multiple times adds only the first object ([#2078](#2078)) ([0f98117](0f98117))
|
🎉 This change has been released in version 4.3.1-alpha.2 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 17, 2024
# [5.0.0-beta.1](4.3.1...5.0.0-beta.1) (2024-03-17) ### Bug Fixes * Calling `Parse.Object.relation.add` multiple times adds only the first object ([#2078](#2078)) ([0f98117](0f98117)) ### Features * Add comment to MongoDB query via `Parse.Query.comment` ([#2088](#2088)) ([a970913](a970913)) * Add compatibility with Parse Server 7 ([#2089](#2089)) ([86600bc](86600bc)) * Add support for Node 20, remove support for Node 14 and 16 ([#2063](#2063)) ([74eb4d5](74eb4d5)) ### BREAKING CHANGES * Parse JS SDK 5 requires Parse Server 7 and is incompatible with Parse Server 6. ([86600bc](86600bc)) * Removes support for Node 14 and 16. ([74eb4d5](74eb4d5))
|
🎉 This change has been released in version 5.0.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 17, 2024
# [5.0.0](4.3.1...5.0.0) (2024-03-17) ### Bug Fixes * Calling `Parse.Object.relation.add` multiple times adds only the first object ([#2078](#2078)) ([0f98117](0f98117)) ### Features * Add comment to MongoDB query via `Parse.Query.comment` ([#2088](#2088)) ([a970913](a970913)) * Add compatibility with Parse Server 7 ([#2089](#2089)) ([86600bc](86600bc)) * Add support for Node 20, remove support for Node 14 and 16 ([#2063](#2063)) ([74eb4d5](74eb4d5)) ### BREAKING CHANGES * Parse JS SDK 5 requires Parse Server 7 and is incompatible with Parse Server 6. ([86600bc](86600bc)) * Removes support for Node 14 and 16. ([74eb4d5](74eb4d5))
|
🎉 This change has been released in version 5.0.0 |
mtrezza
added a commit
to mtrezza/Parse-SDK-JS
that referenced
this pull request
Mar 23, 2024
…rification * alpha: chore(release): 5.0.0-beta.1 [skip ci] chore(release): 5.0.0-alpha.3 [skip ci] feat: Add comment to MongoDB query via `Parse.Query.comment` (parse-community#2088) chore(release): 5.0.0-alpha.2 [skip ci] feat: Add compatibility with Parse Server 7 (parse-community#2089) chore(release): 5.0.0-alpha.1 [skip ci] feat: Add support for Node 20, remove support for Node 14 and 16 (parse-community#2063) refactor: Upgrade ws from 8.15.1 to 8.16.0 (parse-community#2087) ci: Remove manual caching for `actions/setup-node` (parse-community#2064) chore(release): 4.3.1-alpha.2 [skip ci] fix: Calling `Parse.Object.relation.add` multiple times adds only the first object (parse-community#2078) refactor: Upgrade ws from 8.15.0 to 8.15.1 (parse-community#2074) chore(release): 4.3.1 [skip ci] release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Closes: #2056
Approach
ParseOp.applyTo: Take as parameter not just the className and objectId, but the whole object.
This allows ObjectStateMutations.estimateAttributes to return relations with correct parents
Tasks