Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Apr 23, 2019

Closes: #796

Let me know you have questions or if I missed something.

@dplewis dplewis requested a review from acinader April 23, 2019 19:24
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #801 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   92.02%   92.03%   +<.01%     
==========================================
  Files          54       54              
  Lines        4917     4920       +3     
  Branches     1091     1092       +1     
==========================================
+ Hits         4525     4528       +3     
  Misses        392      392
Impacted Files Coverage Δ
src/LocalDatastore.js 98.71% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab0542...e55e5f2. Read the comment docs.

@dplewis dplewis merged commit 1d30b03 into master Apr 24, 2019
@dplewis dplewis deleted the lds-support-users branch April 24, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pinAllWithName fails when saving User objects

2 participants