Skip to content

Conversation

einsqing
Copy link
Contributor

@einsqing einsqing commented Jul 23, 2019

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you are doing now. I added a few comments and questions below.

Can you check the travis build and run npm run lint on your code.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #874 into master will decrease coverage by 0.1%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   92.14%   92.04%   -0.11%     
==========================================
  Files          54       54              
  Lines        5006     5016      +10     
  Branches     1121     1126       +5     
==========================================
+ Hits         4613     4617       +4     
- Misses        393      399       +6
Impacted Files Coverage Δ
src/LiveQueryClient.js 85.63% <0%> (-1%) ⬇️
src/Storage.js 94.44% <50%> (-1.71%) ⬇️
src/LocalDatastore.js 98.29% <50%> (-0.42%) ⬇️
src/RESTController.js 81.2% <50%> (-0.43%) ⬇️
src/ParseFile.js 96.93% <50%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b61d04...7ecfd75. Read the comment docs.

@dplewis dplewis requested a review from acinader July 24, 2019 15:01
@dplewis dplewis requested a review from davimacedo July 25, 2019 13:18
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me regarding:

  • I am sure it will not break the other builds
  • The code is perfectly understandable

I haven't tried to create a WeChat app though, but I will probably give a try soon.

@dplewis
Copy link
Member

dplewis commented Jul 25, 2019

@einsqing I updated the readme can you have a look? Also if you have time, you can add LocalDatastore support as well.

@einsqing
Copy link
Contributor Author

@dplewis LocalDatastore has been supported

@dplewis
Copy link
Member

dplewis commented Jul 26, 2019

Is there anything you want to add or change in the readme like documentation or usage with WeChat?

@einsqing
Copy link
Contributor Author

@dplewis Wechat minprogram is limited to 2m in size. Generally, we use dist/parse.weapp.min.js directly. You can also require ("parse/weapp"), but you need to turn on building NPM packages

image

@dplewis
Copy link
Member

dplewis commented Jul 26, 2019

Since you don’t use wx.Parse can you remove it from the PR?

Can you also update the readme with npm run build and copy /dist/parse.weapp.min.js

@einsqing
Copy link
Contributor Author

@dplewis Update readme and remove wx.Parse

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acinader looks good to me. Any comments?

@dplewis dplewis merged commit 2ea5a98 into parse-community:master Jul 28, 2019
@dplewis dplewis mentioned this pull request Mar 24, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants