-
-
Notifications
You must be signed in to change notification settings - Fork 599
Support for Wechat applet #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you are doing now. I added a few comments and questions below.
Can you check the travis build and run npm run lint
on your code.
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 92.14% 92.04% -0.11%
==========================================
Files 54 54
Lines 5006 5016 +10
Branches 1121 1126 +5
==========================================
+ Hits 4613 4617 +4
- Misses 393 399 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me regarding:
- I am sure it will not break the other builds
- The code is perfectly understandable
I haven't tried to create a WeChat app though, but I will probably give a try soon.
@einsqing I updated the readme can you have a look? Also if you have time, you can add LocalDatastore support as well. |
@dplewis LocalDatastore has been supported |
Is there anything you want to add or change in the readme like documentation or usage with WeChat? |
@dplewis Wechat minprogram is limited to 2m in size. Generally, we use dist/parse.weapp.min.js directly. You can also require ("parse/weapp"), but you need to turn on building NPM packages |
Since you don’t use wx.Parse can you remove it from the PR? Can you also update the readme with npm run build and copy /dist/parse.weapp.min.js |
@dplewis Update readme and remove wx.Parse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acinader looks good to me. Any comments?
Support for Wechat applet,https://developers.weixin.qq.com/miniprogram/en/dev/