Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 14, 2019

Closes: #899, #955

Any advice or a different implementation would be appreciated.

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #956 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   91.94%   91.94%           
=======================================
  Files          54       54           
  Lines        5064     5064           
  Branches     1137     1137           
=======================================
  Hits         4656     4656           
  Misses        408      408
Impacted Files Coverage Δ
src/ParseObject.js 89.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee9c14...ed8ca2e. Read the comment docs.

dplewis added a commit that referenced this pull request Oct 14, 2019
@dplewis dplewis mentioned this pull request Oct 14, 2019
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems exactly right to me, both in being 'more correct' and also solving the issues raised.

@dplewis dplewis merged commit dc26b15 into master Oct 15, 2019
@dplewis dplewis deleted the generate-localID branch October 15, 2019 17:10
dplewis added a commit that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse.query on local datastore objects returns other local object attributes or null

2 participants