Fix: Remove options from Parse.Schema #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #941 Fixes Documentation `useMasterKey: true` is sent with every Parse.Schema request so passing it and sessionToken as a parameter is redundant.
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
==========================================
- Coverage 91.92% 91.89% -0.03%
==========================================
Files 54 54
Lines 5076 5060 -16
Branches 1139 1134 -5
==========================================
- Hits 4666 4650 -16
Misses 410 410
Continue to review full report at Codecov.
|
acinader
reviewed
Oct 15, 2019
src/ParseSchema.js
Outdated
| get(className: string, options: RequestOptions): Promise { | ||
| return this.send(className, 'GET', {}, options); | ||
| get(className: string): Promise { | ||
| return this.send(className, 'GET', {}); |
There was a problem hiding this comment.
what happens if you just do this.send(className, 'GET')
or this.send(className, 'DELETE')
would be nice if send set the default param of {} instead of using here?
This was referenced Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #941
Fixes Documentation.
useMasterKey: trueis sent with every Parse.Schema request so passing it and sessionToken as a parameter is redundant.https://github.com/parse-community/parse-server/blob/master/src/Routers/SchemasRouter.js#L124