Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 15, 2019

Closes: #583

Let me know if there are any other tests needed.
I rarely use CLPs so I may miss something.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #960 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #960      +/-   ##
=========================================
+ Coverage   91.89%   91.9%   +<.01%     
=========================================
  Files          54      54              
  Lines        5060    5063       +3     
  Branches     1134    1134              
=========================================
+ Hits         4650    4653       +3     
  Misses        410     410
Impacted Files Coverage Δ
src/ParseSchema.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c5b0d9...e70e726. Read the comment docs.

@dplewis
Copy link
Member Author

dplewis commented Oct 15, 2019

@acinader How does this look?

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! let's get it out there and see what we missed ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLP needs an API

2 participants