Can unlink without provider (cloud code) #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is specifically for facebook since you can't register a auth provider in cloud code (FB doesn't exist). Removes duplicate logic (linkWith handles the providers) ``` Cannot read property 'getAuthType' of undefined ``` Note: I can't add an integration test for this. `integration/server.js` uses /node_modules/parse `integration/tests` uses /lib/node If they could both use /lib/node that would open the door for testing different cloud code function.
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 91.88% 91.84% -0.05%
==========================================
Files 54 54
Lines 5080 5078 -2
Branches 1143 1142 -1
==========================================
- Hits 4668 4664 -4
- Misses 412 414 +2
Continue to review full report at Codecov.
|
This was referenced Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is specifically for facebook since you can't register a auth provider in cloud code (FB doesn't exist).
Removes duplicate logic (linkWith handles the providers)
Note: I can't add an integration test for this. I have tested and this works.
integration/testsuses /lib/nodeintegration/server.jsuses /node_modules/parse (this doesn't have changes made in /lib/node)