Skip to content

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Nov 5, 2019

Let me know if changes are needed.

Let me know if changes are needed
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #979 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   91.85%   91.86%   +<.01%     
==========================================
  Files          54       54              
  Lines        5083     5086       +3     
  Branches     1145     1146       +1     
==========================================
+ Hits         4669     4672       +3     
  Misses        414      414
Impacted Files Coverage Δ
src/LiveQuerySubscription.js 100% <ø> (ø) ⬆️
src/LiveQueryClient.js 87.76% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc1081...085c51a. Read the comment docs.

@dplewis dplewis requested a review from acinader November 5, 2019 00:20
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dplewis dplewis merged commit 276a736 into master Nov 5, 2019
@dplewis dplewis deleted the subscription-options branch November 5, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants