- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 874
ci: Add support for Xcode 16 #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for opening this pull request!
 | 
| Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@             Coverage Diff             @@
##           master    #1818       +/-   ##
===========================================
+ Coverage   64.24%   82.80%   +18.56%     
===========================================
  Files         201      282       +81     
  Lines       23233    30726     +7493     
===========================================
+ Hits        14926    25443    +10517     
+ Misses       8307     5283     -3024     ☔ View full report in Codecov by Sentry. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! What happened to the tests (build:starters) though?
| Xcode 14, 15, 16 runs  | 
| Oh, now I saw it in the changes. I'll add that to the TODOs | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| I feel like this deserves a changelog entry. Normally, when we add support for a platform version, we have a changelog entry, but the README does not state any specific IDE or OS compatibility. It says iOS 12 for example, but what should that mean? | 
New Pull Request Checklist
Issue Description
CI is currently not testing with Xcode 16.
Closes: #1812
Closes: #1799
Approach
TODOs before merging