New Config Method .save() #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
flovilmart
suggested changes
Nov 13, 2018
_includes/js/config.md
Outdated
| ageOfParse : 3, | ||
| tags : ["parse","sdk","js"] | ||
| }).then(function(config) { | ||
| console.log("Cool! Config was saved ans fetched from the server."); |
There was a problem hiding this comment.
typo:
Suggested change
| console.log("Cool! Config was saved ans fetched from the server."); | |
| console.log("Cool! Config was saved and fetched from the server."); |
_includes/js/config.md
Outdated
| }).then(function(config) { | ||
| console.log("Cool! Config was saved ans fetched from the server."); | ||
|
|
||
| var welcomeMessage = config.get("welcomeMessage"); |
There was a problem hiding this comment.
prefer const, it's 2018 :)
Suggested change
| var welcomeMessage = config.get("welcomeMessage"); | |
| const welcomeMessage = config.get("welcomeMessage"); |
_includes/js/config.md
Outdated
| ``` | ||
| ## Save a Config | ||
|
|
||
| `ParseConfig` can be managed through the SDK when a `Master Key` is provided. You can save new parameters and if you save already existing parameters they will be automatically updated. |
There was a problem hiding this comment.
when a
Master Keyis provided
ie: only in nodejs :)
There was a problem hiding this comment.
it doesn't works in a browser with a masterkey ?
There was a problem hiding this comment.
Master key should NEVER be exposed in the browser! and the JS SDK doesn’t support passing a third argument.
|
I just noticed that that i forgot to transform |
|
Not a big deal :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR Parse.Config.save()