Skip to content

refactor: use ref API instead of findDOMNode #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 30, 2022
Merged

refactor: use ref API instead of findDOMNode #1952

merged 16 commits into from
Sep 30, 2022

Conversation

@damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Dec 7, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

As a part of modernizing the project and making the way towards upgrading to React 17+, we need to replace findDOMNode with createRef as findDOMNode is not available in strict-mode.

Related issue: #1950

Approach

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 7, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik marked this pull request as ready for review September 29, 2022 20:52
@damianstasik damianstasik requested a review from a team September 29, 2022 20:52
@mtrezza mtrezza changed the title refactor: use ref API instead of findDOMNode refactor: use ref API instead of findDOMNode Sep 29, 2022
@mtrezza mtrezza merged commit 69557f3 into parse-community:alpha Sep 30, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 9, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 17, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damianstasik @parseplatformorg @mtrezza @visualfanatic