Skip to content

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Apr 26, 2025

New Pull Request Checklist

Issue Description

Closes: #2742

Approach

TODOs before merging

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: clicking on pointer link resets skip fix: Clicking on pointer link resets skip Apr 26, 2025
Copy link

parse-github-assistant bot commented Apr 26, 2025

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Apr 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

uffizzi-cloud bot commented Apr 26, 2025

Uffizzi Ephemeral Environment deployment-63182

⌚ Updated Apr 26, 2025, 10:14 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2767

📄 View Application Logs etc.

What is Uffizzi? Learn more

Copy link

coderabbitai bot commented Apr 28, 2025

📝 Walkthrough

"""

Walkthrough

The change updates the handlePointerClick method in the Browser.react.js file to reset the pagination offset (skip) to zero whenever a pointer click navigates to a filtered browser view. This ensures that after clicking a pointer link, the pagination state is reset and the user is shown the first page of results. No other logic, control flow, or exported/public entity declarations are modified.

Changes

File(s) Change Summary
src/dashboard/Data/Browser/Browser.react.js Adds this.setState({ skip: 0 }) after navigation in handlePointerClick to reset pagination

Assessment against linked issues

Objective Addressed Explanation
Reset pagination params when clicking pointer links to filtered views (#2742)
Ensure navigation to filtered object view does not retain previous page offset (#2742)
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d52e80 and efcd757.

📒 Files selected for processing (1)
  • src/dashboard/Data/Browser/Browser.react.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/dashboard/Data/Browser/Browser.react.js
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Docker linux/amd64
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 28, 2025
@mtrezza mtrezza closed this Apr 29, 2025
@mtrezza mtrezza reopened this Apr 29, 2025
Copy link

uffizzi-cloud bot commented Apr 29, 2025

Uffizzi Ephemeral Environment deployment-63244

⌚ Updated Apr 29, 2025, 01:21 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2767

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza changed the title fix: Clicking on pointer link resets skip fix: Clicking on pointer in data browser when using pagination does not reset to first page Apr 29, 2025
@mtrezza mtrezza merged commit ab512e5 into parse-community:alpha Apr 29, 2025
10 of 11 checks passed
parseplatformorg pushed a commit that referenced this pull request Apr 29, 2025
# [7.1.0-alpha.12](7.1.0-alpha.11...7.1.0-alpha.12) (2025-04-29)

### Bug Fixes

* Clicking on pointer in data browser when using pagination does not reset to first page ([#2767](#2767)) ([ab512e5](ab512e5))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.12

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 29, 2025
parseplatformorg pushed a commit that referenced this pull request May 1, 2025
# [7.1.0](7.0.0...7.1.0) (2025-05-01)

### Bug Fixes

* Clicking on pointer in data browser when using pagination does not reset to first page ([#2767](#2767)) ([ab512e5](ab512e5))
* Dashboard crashes on login due to `passport` upgrade ([#2758](#2758)) ([ee74321](ee74321))
* Dashboard crashes when selecting app ([#2747](#2747)) ([8b0cfea](8b0cfea))
* Data browser filters "key exists" and "key does not exist" not working ([#2760](#2760)) ([0691b3c](0691b3c))
* Data browser filters "key exists" and "key does not exist" not working ([#2762](#2762)) ([099eca3](099eca3))
* Data loading indicator not showing when using pagination ([#2768](#2768)) ([62d7aec](62d7aec))
* Improperly aligned unfolding sub-items in context menu in data browser  ([#2713](#2713)) ([189c817](189c817))
* Logout bar layout not aligned with data browser navigation bar ([#2720](#2720)) ([01a2a1c](01a2a1c))
* Navigation bar in data browser is transparent and partly covers info panel ([#2717](#2717)) ([60b38a5](60b38a5))
* Obsolete, long-running data fetch request overrides displayed data of newer fetch request in the data browser ([#2715](#2715)) ([31668eb](31668eb))

### Features

* Add pagination to data browser ([#2659](#2659)) ([a3c8a11](a3c8a11))
* Allow row selection in data browser by dragging mouse outside of selection box column ([#2716](#2716)) ([7c0f607](7c0f607))
* Display filter list in data browser sorted alphabetically ([#2761](#2761)) ([0209a0d](0209a0d))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2025
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request May 6, 2025
* source: (58 commits)
  chore(release): 7.1.0 [skip ci]
  empty commit to trigger CI
  refactor: Bump webpack-cli from 5.0.1 to 6.0.1 (parse-community#2772)
  refactor: Bump @babel/plugin-proposal-decorators from 7.20.13 to 7.25.9 (parse-community#2773)
  refactor: Bump eslint-plugin-react from 7.37.4 to 7.37.5 (parse-community#2764)
  chore(release): 7.1.0-alpha.12 [skip ci]
  fix: Clicking on pointer in data browser when using pagination does not reset to first page (parse-community#2767)
  chore(release): 7.1.0-alpha.11 [skip ci]
  fix: Data loading indicator not showing when using pagination (parse-community#2768)
  chore(release): 7.1.0-alpha.10 [skip ci]
  fix: Data browser filters "key exists" and "key does not exist" not working (parse-community#2762)
  refactor: Bump puppeteer from 24.6.0 to 24.6.1 (parse-community#2750)
  chore(release): 7.1.0-alpha.9 [skip ci]
  feat: Display filter list in data browser sorted alphabetically (parse-community#2761)
  chore(release): 7.1.0-alpha.8 [skip ci]
  fix: Data browser filters "key exists" and "key does not exist" not working (parse-community#2760)
  chore(release): 7.1.0-alpha.7 [skip ci]
  fix: Dashboard crashes on login due to `passport` upgrade (parse-community#2758)
  refactor: Bump http-server from 14.0.0 to 14.1.1 (parse-community#2757)
  refactor: Bump webpack from 5.94.0 to 5.99.5 (parse-community#2751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on pointer link shows no object due to pagination

3 participants