Skip to content

fix: Saving new filter in data browser overwrites filters added in other dashboard instances #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025
Merged

fix: Saving new filter in data browser overwrites filters added in other dashboard instances #2769

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46e1ce7
Update ClassPreferences.js
dblythy Apr 27, 2025
eb821d5
Update ClassPreferences.js
dblythy Apr 27, 2025
530645e
Merge branch 'alpha' into fix/save-filters
mtrezza Apr 28, 2025
fdf4f4b
Merge branch 'alpha' into fix/save-filters
mtrezza May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/lib/ClassPreferences.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
const VERSION = 1; // In case we ever need to invalidate these
const cache = {};
export function updatePreferences(prefs, appId, className) {
try {
localStorage.setItem(path(appId, className), JSON.stringify(prefs));
} catch {
// Fails in Safari private browsing
}
cache[appId] = cache[appId] || {};
cache[appId][className] = prefs;
}

export function getPreferences(appId, className) {
if (cache[appId] && cache[appId][className]) {
return cache[appId][className];
}
let entry;
try {
entry =
Expand All @@ -29,10 +23,7 @@ export function getPreferences(appId, className) {
return null;
}
try {
const prefs = JSON.parse(entry);
cache[appId] = cache[appId] || {};
cache[appId][className] = prefs;
return prefs;
return JSON.parse(entry);
} catch {
return null;
}
Expand Down
Loading