Skip to content

fix: Pagination footer bar hides rows in data browser #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

fix: Pagination footer bar hides rows in data browser #2879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b453fe
fix: keep rows visible above footer
mtrezza Jul 9, 2025
26658fe
Merge branch 'alpha' into codex/fix-browserfooter-overlapping-table-rows
mtrezza Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/BrowserCell/BrowserCell.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,12 @@ export default class BrowserCell extends Component {

// BrowserToolbar + DataBrowserHeader height
const topBoundary = 126;
// Account for BrowserFooter height when checking the bottom boundary
const bottomBoundary = window.innerHeight - 36;

if (left < leftBoundary || right > window.innerWidth) {
node.scrollIntoView({ block: 'nearest', inline: 'start' });
} else if (top < topBoundary || bottom > window.innerHeight) {
} else if (top < topBoundary || bottom > bottomBoundary) {
node.scrollIntoView({ block: 'nearest', inline: 'nearest' });
}
}
Expand Down
Loading