Adds support for readOnly masterKey #787
Conversation
flovilmart
force-pushed
the
read-only-masterKey
branch
from
b6bc8d0 to
3c13c58
Compare
| app.get('/parse-dashboard-config.json', function(req, res) { | ||
| let response = { | ||
| apps: config.apps, | ||
| apps: [...config.apps], // make a copy |
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
This is awesome and we'll use it for sure.
As usual, I have a bunch of nits that you can take or leave ;). it's just how I read.
Parse-Dashboard/app.js
Outdated
| response.apps = response.apps.filter(function (app) { | ||
| return appsUserHasAccess.find(appUserHasAccess => { | ||
| return app.appId == appUserHasAccess.appId | ||
| const isSame = app.appId == appUserHasAccess.appId; |
There was a problem hiding this comment.
prefer === :). i know its not yours....
Parse-Dashboard/Authentication.js
Outdated
| function authenticate(userToTest, usernameOnly) { | ||
| var appsUserHasAccessTo = null; | ||
| var matchingUsername = null; | ||
| var isReadOnly = false; |
There was a problem hiding this comment.
switch all these to let? your call :)....
| } | ||
|
|
||
| return isAuthenticated; | ||
| }) ? true : false; |
There was a problem hiding this comment.
ewww, remove the ? true: false? as completely redundant?
Parse-Dashboard/Authentication.js
Outdated
|
|
||
| return isAuthenticated; | ||
| }) ? true : false; | ||
| }) ? true : false ; |
There was a problem hiding this comment.
no because of the && && it was returning an object instead of true / false, and was breaking some tests.
README.md
Outdated
|
|
||
| ### Making an app read-only for all users | ||
|
|
||
| Start your parse server with |
There was a problem hiding this comment.
parse-server for consistency?
There was a problem hiding this comment.
also could put readOnlyMasterKey masterKey insteaxc of masterKey....i.e. mark as code.
* Adds support for readOnly masterKey * nits * Adds tests for readOnly * Updates documentation * nit * nits
No description provided.