afterLiveQueryEvent hook returns empty date object

[NuclleaR]

New Issue Checklist

• I am not disclosing a vulnerability.
• I am not just asking a question.
• I have searched through existing issues.
• I can reproduce the issue with the latest version of Parse Server.

Issue Description

Date object is empty in afterLiveQueryEvent hook.

Steps to reproduce

Created hook

Parse.Cloud.afterLiveQueryEvent('Spendings', async function(request) {
  const category = await getCategory(request.object.get('category'));
  const store = await getStore(request.object.get('store'));

  console.log('===> request.object', JSON.stringify(request.object));

  request.object.set('category', category);
  request.object.set('store', store);
});

Actual Outcome

log that I received. date is empty
===> request.object {"date":{},"amount":444,"createdAt":"2020-12-18T13:21:49.770Z","category":{"__type":"Pointer","className":"Categories","objectId":"SREwh7FEwF"},"parent":{"__type":"Pointer","className":"ParentCategory","objectId":"yomXRG8Hcj"},"updatedAt":"2020-12-18T13:21:49.770Z","objectId":"3MdGVC5NuY"}

Expected Outcome

expected date object

Failing Test Case / Pull Request

• 🧐 I submitted a PR with a failing test case.
• 🤩 I submitted a PR with a fix and a test case.

Environment

Server

• Parse Server version: 4.5.0
• Operating system: OSX 11.0.1
• Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): Local
• NodeJs: v14.0.0

Database

• System (MongoDB or Postgres): MongoDB
• Database version: 4.2.11
• Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): MongoDB Atlas

Client

• SDK (iOS, Android, JavaScript, PHP, Unity, etc): Flutter SDK
• SDK version: 2.0.1

Logs

info: beforeSave triggered for Spendings for user undefined:
  Input: {"amount":444,"date":{"__type":"Date","iso":"2020-12-18T13:21:40.088Z"},"category":{"__type":"Pointer","className":"Categories","objectId":"SREwh7FEwF"},"parent":{"__type":"Pointer","className":"ParentCategory","objectId":"yomXRG8Hcj"}}
  Result: {"object":{"date":{"__type":"Date","iso":"2020-12-18T13:21:40.088Z"},"amount":444,"category":{"__type":"Pointer","className":"Categories","objectId":"SREwh7FEwF"},"parent":{"__type":"Pointer","className":"ParentCategory","objectId":"yomXRG8Hcj"}}} {"className":"Spendings","triggerType":"beforeSave"}
info: afterSave triggered for Spendings for user undefined:
  Input: {"date":{"__type":"Date","iso":"2020-12-18T13:21:40.088Z"},"amount":444,"createdAt":"2020-12-18T13:21:49.770Z","category":{"__type":"Pointer","className":"Categories","objectId":"SREwh7FEwF"},"parent":{"__type":"Pointer","className":"ParentCategory","objectId":"yomXRG8Hcj"},"updatedAt":"2020-12-18T13:21:49.770Z","objectId":"3MdGVC5NuY"} {"className":"Spendings","triggerType":"afterSave"}
===> request.object {"date":{},"amount":444,"createdAt":"2020-12-18T13:21:49.770Z","category":{"__type":"Pointer","className":"Categories","objectId":"SREwh7FEwF"},"parent":{"__type":"Pointer","className":"ParentCategory","objectId":"yomXRG8Hcj"},"updatedAt":"2020-12-18T13:21:49.770Z","objectId":"3MdGVC5NuY"}

[NuclleaR]

Flutter SDK throws Unhandled Exception: type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'DateTime'

Issue just with live query. with REST request all works as expected

[mtrezza]

Thanks for reporting.

Issue just with live query. with REST request all works as expected

Do you mean that the issue has only been observed with the Flutter SDK? Then this may be an SDK issue rather than a Parse Server issue. It would help if you could try to write a failing test case here, then we would know whether this issue also exists for the Parse JS SDK and/or for Parse Server in general.

[NuclleaR]

@mtrezza Hello! Logs that I provided I grabbed from Node Js server logs. So, I believe this is could be server issue, not Flutter SDK.

[mtrezza]

Thanks for clarifying, and what exactly did you mean by:

with REST request all works as expected

Can you post the REST request?

[dblythy]

I will write a test case in an hour or so to see what's going on. The afterLiveQueryEvent trigger should be able to handle dates so it seems strange to me.

I would recommend using Promise.all in your code tho so getCategory and getStore run in parallel (i.e, so they run at the same time, rather than one by one)

Parse.Cloud.afterLiveQueryEvent('Spendings', async function(request) {
  const [category, store] = await Promise.all([getCategory(request.object.get('category')),getStore(request.object.get('store')]);
  request.object.set('category', category);
  request.object.set('store', store);
});

[dblythy]

it('afterEvent should work with date', async done => {
    await reconfigureServer({
      liveQuery: {
        classNames: ['TestObject'],
      },
      startLiveQueryServer: true
    });
    Parse.Cloud.afterLiveQueryEvent('TestObject', request => {
      const date = request.object.get('date');
      expect(date).toBeDefined();
      expect(date).toBeInstanceOf(Date);
      console.log('===> request.object', JSON.stringify(request.object));
      done();
    });

    const query = new Parse.Query(TestObject);
    await query.subscribe(); 

    const object = new TestObject();
    object.set('date', new Date());
    await object.save();
});

This test passes for me

[NuclleaR]

@dblythy Hello!
Seems like I found case when issue reproduces in 100% cases.
In your test everything works coz you change date and save, but if you update object with any another field and don't touch date, date will come empty object. at least it reproduces in my project in 100% cases

[dblythy]

So is this your use case?

it('afterEvent should work with date', async done => {
    await reconfigureServer({
      liveQuery: {
        classNames: ['TestObject'],
      },
      startLiveQueryServer: true
    });
    let calls = 0;
    Parse.Cloud.afterLiveQueryEvent('TestObject', request => {
      const date = request.object.get('date');
      expect(date).toBeDefined();
      expect(date).toBeInstanceOf(Date);
      console.log('===> request.object', JSON.stringify(request.object));
      calls++;
      if (calls == 2) {
        done();
      }
    });

    const query = new Parse.Query(TestObject);
    await query.subscribe(); 

    const object = new TestObject();
    object.set('date', new Date());
    await object.save();
    object._clearServerData();

    const obj = await query.first();
    obj.set('foo','bar');
    await obj.save();
});

If you could write a failing test it would really help us get to the bottom of the bug.

[NuclleaR]

I found real issue.
I debug a lilbit this method and figure out

export async function maybeRunAfterEventTrigger(triggerType, className, request) {
  const trigger = getTrigger(className, triggerType, Parse.applicationId);
  if (!trigger) {
    return;
  }
  if (request.object) {
    // Here is the issue where date become '{}'
    request.object = Parse.Object.fromJSON(request.object);
  }
  if (request.original) {
    request.original = Parse.Object.fromJSON(request.original);
  }
  request.user = await userForSessionToken(request.sessionToken);
  await maybeRunValidator(request, `${triggerType}.${className}`);
  if (request.skipWithMasterKey) {
    return;
  }
  return trigger(request);
}

I wrote test, and test fails

const Parse = require('parse/node');

describe('From JSON', () => {
  it('should return object from JSON', () => {
    const TestObject = {
      className: 'TestObject',
      __type: 'Object',
      Hello: 'World',
      date: new Date(),
      someValue: 123,
    };

    const parsed = Parse.Object.fromJSON(TestObject);

    expect(parsed.get('someValue')).toBeInstanceOf(Number); // => true
    expect(parsed.get('date')).toBeInstanceOf(Date); // => false
  });
});

[NuclleaR]

@dblythy could you take a look, please, and confirm?

here is my real log from real app
date comes like JS Date object not a { __type: 'Date' }

date: 2021-01-15T17:51:39.403Z,
amount: 551,
category: {
__type: 'Pointer',
className: 'Categories',
objectId: 'WSRUJzVwOE'
},
parent: {
__type: 'Pointer',
className: 'ParentCategory',
objectId: 'mTDh4FXkno'
},
createdAt: '2021-01-15T15:51:45.343Z',
updatedAt: '2021-01-15T16:09:43.181Z',
__type: 'Object',
className: 'Spendings',
objectId: 'VC8PHzCW0i'
}

[mtrezza]

This has been classified as a bug with severity 2:

• Workaround: unknown
• Fix: needs investigation