Fixing #1900 JS SDK file upload #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS SDK file upload uses req.body._ContentType to specify the upload content type
ghost
added
the
|
@blacha updated the pull request. |
|
@blacha updated the pull request. |
Current coverage is 91.91%
@@ master #1935 diff @@
==========================================
Files 91 91
Lines 6396 6468 +72
Methods 1097 1118 +21
Messages 0 0
Branches 1340 1369 +29
==========================================
+ Hits 5875 5945 +70
- Misses 521 523 +2
Partials 0 0
|
|
@blacha updated the pull request. |
|
Awesome! |
| } | ||
| if (req.body._ContentType) { | ||
| req.headers['content-type'] = req.body._ContentType; | ||
| delete req.body_contentType; |
There was a problem hiding this comment.
Shouldn't this be body._ContentType?
|
Yep you're right! I'll patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS SDK file upload uses req.body._ContentType to specify the upload content type