Recursive parse date in cloud function #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 91.92%@@ master #2014 diff @@
==========================================
Files 91 91
Lines 6420 6431 +11
Methods 1096 1099 +3
Messages 0 0
Branches 1347 1350 +3
==========================================
+ Hits 5901 5912 +11
Misses 519 519
Partials 0 0
|
src/Routers/FunctionsRouter.js
Outdated
| import PromiseRouter from '../PromiseRouter'; | ||
|
|
||
| function parseDate(params) { | ||
| for (let key in params) { |
There was a problem hiding this comment.
Can you use _.mapValues here? Other than that this looks good!
|
Just one thing to fix. Thanks for the PR! |
|
@Marco129 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1826