Add support for running tests on Windows #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| "pretest": "MONGODB_VERSION=${MONGODB_VERSION:=3.0.8} mongodb-runner start", | ||
| "test": "NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node ./node_modules/.bin/babel-istanbul cover -x **/spec/** ./node_modules/.bin/jasmine", | ||
| "pretest": "cross-env MONGODB_VERSION=${MONGODB_VERSION:=3.0.8} ./node_modules/.bin/mongodb-runner start", | ||
| "test": "cross-env NODE_ENV=test TESTING=1 ./node_modules/.bin/babel-node ./node_modules/babel-istanbul/lib/cli.js cover -x **/spec/** node_modules/jasmine/bin/jasmine.js", |
There was a problem hiding this comment.
I realise I dropped a ./ on the path to jasmine. Not sure what the best practice is here but would change to be consistent
|
@steven-supersolid updated the pull request. |
|
Cool! @steven-supersolid If you can also update our |
drew-gross
added a commit
that referenced
this pull request
Feb 11, 2016
Add support for running tests on Windows
|
@drew-gross That's still something I have to learn, but preliminary look shows Windows might not be supported by Travis? travis-ci/travis-ci#216 |
|
Ah. I saw that issue, didn't want to read the whole thing, and assumed since it was closed, and I knew OSX was now supported, that meant windows was also supported, My bad! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-env or similar is required for setting environment variables
js paths instead of cmd paths required on Windows
I'm not sure if we need ./node_modules/.bin/babel-node as babel-istanbul includes babel? Would like to remove if not required to simplify and slim the package down.