Skip to content

(chore): Fix codecov #5554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2019
Merged

(chore): Fix codecov #5554

merged 1 commit into from
May 4, 2019

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented May 2, 2019 •
edited
Loading

@codecov
Copy link

codecov bot commented May 2, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1b0d20d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5554   +/-   ##
=========================================
  Coverage          ?   94.06%           
=========================================
  Files             ?      129           
  Lines             ?     9210           
  Branches          ?        0           
=========================================
  Hits              ?     8663           
  Misses            ?      547           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0d20d...22526a3. Read the comment docs.

@dplewis dplewis requested a review from acinader May 2, 2019 13:23
@dplewis dplewis changed the title (chore): Fix broken codecov (chore): Fix codecov May 2, 2019
@acinader
Copy link
Contributor

acinader commented May 2, 2019

any idea why it was broken and why this fixes it??

@dplewis
Copy link
Member Author

dplewis commented May 2, 2019 •
edited
Loading

It might be an internal fix for exclude and include.

As you can see /src was excluded before.

acinader
acinader approved these changes May 4, 2019
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't quite get it, but no harm!

@acinader acinader merged commit 87b0093 into master May 4, 2019
@dplewis
Copy link
Member Author

dplewis commented May 4, 2019

Story of my life lol

@dplewis dplewis deleted the nyc-fix branch May 4, 2019 13:54
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@dplewis @acinader
(chore): Fix broken codecov (parse-community#5554)
421e85d
@yozef yozef mentioned this pull request Mar 26, 2024
Open
@kiarza2543 kiarza2543 mentioned this pull request Mar 26, 2024
Open
@skmezanul skmezanul mentioned this pull request Mar 26, 2024
Open
@ajesse11x ajesse11x mentioned this pull request Mar 26, 2024
Open
@Arul- Arul- mentioned this pull request Mar 26, 2024
Open
@Bhanditz Bhanditz mentioned this pull request Mar 27, 2024
Open
@pradyum07 pradyum07 mentioned this pull request Mar 27, 2024
Open
This was referenced Mar 27, 2024
Merged
Closed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 31, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 30, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@acinader acinader acinader approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dplewis @acinader @parseplatformorg