Improve LocalStreamWriter along with error types #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR disallows taking stream_writer as mutable if any inner mutex is held . File creation logic is improved and is now atomic, no two threads can call set_entry at the same time. File creation was not guarded well so there could have arrived a situation where two threads tried to create the file then in that case one of thread would have failed and errored. Changes - set_entry takes writer which ensures no other thread can call set_entry at the same time. File creation is atomic. - Addded error type StreamWriterError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disallows taking stream_writer as mutable if any inner mutex is held . File creation logic is improved and is now atomic, no two threads can call set_entry at the same time. File creation was not guarded well so there could have arrived a situation where two threads tried to create the file then in that case one of thread would have failed and errored.
Changes
This PR has: